Reddit Experience · Feb 2024

Ownership of Large PRs

65 upvotes 84 replies

Interview Experience

I've been exploring how other teams handle large PRs. We generally push for breaking these PRs apart, but there will always be cases where they are slipping through. I notice that engineers can spend

Full Details

I've been exploring how other teams handle large PRs. We generally push for breaking these PRs apart, but there will always be cases where they are slipping through. I notice that engineers can spend an hour or longer reviewing the changes to meet our quality standards or just giving up and approving. Our team has a general culture of pushing for deep ownership of the PR on the author to reduce the burden on other team members, but this isn't always possible with GitHub. Even if someone leaves comments across multiple files with explanations, it can be hard to track. How does everyone handle this? Are there tools we can use or processes that would make this easier? If there isn't already a tool, can you imagine one helping with this?

About This Question

This is a candidate experience report from a github interview for a swe role reported in 2024.

Difficulty rating: Hard